Skip to content

Fix delete branch perm checking #32654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Dec 4, 2024
Merged

Fix delete branch perm checking #32654

merged 17 commits into from
Dec 4, 2024

Conversation

@lunny
Copy link
Member

@lunny lunny commented Nov 27, 2024

No description provided.

@lunny lunny added the type/bug label Nov 27, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 27, 2024
@lunny lunny marked this pull request as draft November 27, 2024 04:02
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Nov 27, 2024
@lunny lunny added backport/v1.22 and removed modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Nov 27, 2024
@lunny lunny force-pushed the lunny/fix_delete_branch_perm branch from 6cecffc to 070ff9b Compare November 27, 2024 04:13
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Nov 27, 2024
@lunny lunny marked this pull request as ready for review November 27, 2024 04:15
hiifong
hiifong reviewed Nov 27, 2024
View reviewed changes
Zettat123
Zettat123 reviewed Nov 28, 2024
View reviewed changes
wxiaoguang
wxiaoguang reviewed Nov 28, 2024
View reviewed changes
wxiaoguang
wxiaoguang reviewed Nov 28, 2024
View reviewed changes
wxiaoguang
wxiaoguang reviewed Nov 29, 2024
View reviewed changes
wxiaoguang
wxiaoguang reviewed Nov 29, 2024
View reviewed changes
wxiaoguang
wxiaoguang approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still, I think:

  1. it needs some tests
  2. it needs to clarify why checking "pr.Flow == issues_model.PullRequestFlowGithub" (comments)

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 29, 2024
hiifong
hiifong reviewed Nov 30, 2024
View reviewed changes
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Nov 30, 2024
@techknowlogick techknowlogick added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 3, 2024
@lunny lunny marked this pull request as draft December 4, 2024 02:09
@lunny lunny added this to the 1.23.0 milestone Dec 4, 2024
@lunny lunny marked this pull request as ready for review December 4, 2024 02:15
@lunny lunny merged commit 17053e9 into go-gitea:main Dec 4, 2024
26 checks passed
@lunny lunny deleted the lunny/fix_delete_branch_perm branch December 4, 2024 03:59
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 4, 2024
@lunny @GiteaBot
Fix delete branch perm checking (go-gitea#32654)
2b061c6
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 4, 2024
@GiteaBot GiteaBot mentioned this pull request Dec 4, 2024
Merged
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Dec 4, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 4, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
c87deba 
* giteaofficial/main:
  Fix delete branch perm checking (go-gitea#32654)
  Refactor markdown editor and use it for milestone description editor (go-gitea#32688)
  Fix issue title rendering and refactor legacy function names (go-gitea#32703)
  Fix oauth2 login methods (go-gitea#32698)
  Fix word overflow in file search page (go-gitea#32695)
  Add Swift login endpoint (go-gitea#32693)
  Quick fix for license file name (go-gitea#32696)
lunny added a commit that referenced this pull request Dec 4, 2024
@GiteaBot @lunny
Fix delete branch perm checking (#32654) (#32707)
0d1fc2b 
Backport #32654 by @lunny

Co-authored-by: Lunny Xiao <[email protected]>
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this pull request Dec 18, 2024
@stblassitude @VVD
security/vuxml: add records for www/gitea < 1.22.6
44f68d0 
go-gitea/gitea#32810
GHSA-v778-237x-gjrc
go-gitea/gitea#32791
go-gitea/gitea#32654
go-gitea/gitea#32531
go-gitea/gitea#32473

PR:	283389
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wxiaoguang wxiaoguang wxiaoguang approved these changes

+2 more reviewers

@Zettat123 Zettat123 Zettat123 left review comments

@hiifong hiifong hiifong approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code type/bug

Projects

None yet

Milestone

1.23.0

Development

Successfully merging this pull request may close these issues.

6 participants

@lunny @wxiaoguang @Zettat123 @hiifong @techknowlogick @GiteaBot